[TYPO3-core] RFC: Feature: #0016183: Edit TypoScript file content in t3editor

Tobias Liebig mail_typo3 at etobi.de
Wed Nov 10 10:47:41 CET 2010


+1 by reading and testing. (its almost a no-brainer)

although i think new files should only be created, if they contain some code. So it should not create 0 byte sized files.
But i think thats an other issue and can be fixed/changed later (after discuss pros and cons :-)

regards
   tobias 

P.S.: i'm not sure about the rules in this case:
	am i allowed to commit this patch as a follow-up right away or do we need to wait for another +1 and commit it as a "feature" (before b1 is released)


Am 09.11.2010 um 20:54 schrieb Fabrizio Branca:

> And here's the patch file...
> 
> Bye,
> 
> Fabrizio
> 
> 
> 
> On 08.11.2010 09:37, Fabrizio Branca wrote:
>> One little follow-up issue:
>> 
>> If we change
>> 
>> if·(!is_writable($realFileName))·{
>> throw·new·Exception(sprintf('"%s"·is·not·writable.',·$fileName));
>> }
>> 
>> to
>> 
>> if·(is_file($realFileName) && !is_writable($realFileName))·{
>> throw·new·Exception(sprintf('"%s"·is·not·writable.',·$fileName));
>> }
>> 
>> we would be able to simple create those files (even if the don't exist)
>> by simply wrapping
>> 
>> ### <INCLUDE_TYPOSCRIPT: source="FILE:fileadmin/newfiles.ts"> BEGIN:
>> ...Content that should go into a newly created file...
>> ### <INCLUDE_TYPOSCRIPT: source="FILE:fileadmin/newfiles.ts"> END:
>> 
>> Currently this is not possible, because the check will throw an
>> exception as a non existent file is not writable.
>> 
>> Bye,
>> 
>> Fabrizio
> 
> <16183_followup.patch>_______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core



More information about the TYPO3-team-core mailing list