[TYPO3-core] RFC #6001: Bugfix: Install Tool image tests fail when there are spaces in the path name

[Ernesto Baschny [cron IT]]

Hi,

This is a SVN patch request.

Type: Bugfix

BT reference: http://bugs.typo3.org/view.php?id=6001

Branches: trunk, TYPO3_4-4

Problem:

im_path does not allowed to have a "space" in its path. Additionally the
restrictions of path names make it difficult to auto-detect that setting
under Windows (and MacOS with MacPorts).

Solution:

The patch changes the routines to allow spaces in the im_path and quotes
it correctly in the tx_div method.

It additionally adds the %PATH% env-var to the detection routine so that
if you install GM or IM (which usually adds itself to the PATH), it will
work out of the box (on Windows and MacOS machines).

How to test:

In the Install Tool with no im_path configured in your localconf.php,
just go to "Basic Configuration". Make sure you have ImageMagick (or GM)
installed on a path *with a space* in it (e.g. under Windows in
C:\Program Files\ImageMagick\ ...)

It won't work because no space is allowed.

Apply the patch and test again.


Additional Infos:

The Introduction Package will benefit from this changes, as the "1-2-3"
installer will go through this auto-detection and provide a more
seamless experience when installing under Windows and MacOS with IM from
MacPorts).


Cheers,
Ernesto

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6001-trunk.v3.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101109/981e43a9/attachment-0001.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6001-4-4.v3.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101109/981e43a9/attachment-0001.txt>