[TYPO3-core] RFC #16321: Bug: Numeric zero for representation of weekday sunday is not accepted

[Marcus Krause]

Hi!


This is a SVN patch request.

Type: Bugfix

Bugtracker reference:
http://bugs.typo3.org/view.php?id=16321

Branches:
4-3, 4-4, trunk


Problem:
Currently, the scheduler accepts single numeric values only for
representation of weekdays. Lower bound and included is 1, upper bound
and included in range is 7. 1 means Monday, 7 Sunday.

However, even the currently reduced functionality is not fully
compatible with an usual cron entry. Usually numeric zero is also
allowed representing Sunday.


Solution:
Allow '0' for sunday.


Note:
attached patches are made against trunk
the added unit test is supposed to get committed to 4-4 and above
(as tests are not included in 4-3)
@see man 5 crontab
Copying the cron entry weekday part in a local variable is by intention.
It is not desired to manipulate the originally supplied cron entry part.

Anyway, the whole weekday parsing needs some love to accept more
complicated expressions. See existing @todo annotations in class CronCmd.


Marcus.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16321.diff
Type: text/x-diff
Size: 1516 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101109/ff096c50/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16321-test.diff
Type: text/x-diff
Size: 948 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101109/ff096c50/attachment-0003.diff>