[TYPO3-core] RFC: Bug #16250: prototype methods are used to determine the available viewport dimensions in ExtJS plugins
Steffen Gebert
steffen at steffen-gebert.de
Thu Nov 4 21:17:06 CET 2010
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=16250
>
> Problem:
> In our own ExtJS plugins the document.viewport method is used to
> determine the available dimensions of the viewport.
>
> Solution:
> The ExtJS Core methods shall be used - this also fixes an issue with IE6.
Hi Olly / Steffen,
> this also fixes an issue with IE6.
could you explain, what issue?
> // Uses the dimension of the current viewport, but removes the document header
> // and an addtional margin of 40 pixels (e.g. Safari needs this addition)
> - this.fitToElement.setHeight(document.viewport.getHeight() - this.fitToElement.getTop() - 40);
You're removing code, but not the associated comment. Could you please
adjust before commit?
Are you sure that the -40 isn't needed anymore and what the purpose was?
It has been added by SteffenK in #15437 "Refactor of recycler".
SteffenK, do you remember, why it was needed?
Kind regards
Steffen
--
Steffen Gebert
TYPO3 Core Team Member
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
More information about the TYPO3-team-core
mailing list