[TYPO3-core] RFC #10011: New feature: TypoScript Condition to check for installed extensions

Franz Holzinger franz at ttproducts.de
Tue Nov 2 06:51:37 CET 2010


Hello Steffen,

>> But maybe the $tolerance can be achieved by reducing the TYPO3 version
>> number into only 2 numbers with a dot.
>>
>
> exactly, or just by override the rev number by 0.

I have added a new patch with a modified function getVersionDifference. 
It now calls version_compare after it has determined the count of 
numbers inside of the version string.

>>> and you should mention that you copied the parts from EM. So it's kind
>>> of double code which shouldn't be. i'm fine with having these static
>>> functions in t3lib_extMgm, but i also prepared thse moves in the new EM
>>> which i try to present until feature freeze.
>>> Have a look to the already static functions:
>>>
>>>
>>> http://forge.typo3.org/projects/typo3v4-em/repository/entry/trunk/classes/tools/class.em_staticfunctions.php
>>>
>>
>> Where is the correct place for new functions of the EM?
>> Will the file class.t3lib_extmgm.php be removed in the future?
>>
>
> the refactor isn't finished yet. Some specific funtions will remain in
> EM, the general one will be moved to t3lib.

IMHO the refactoring of the call of the duplicate function code should 
be a new RFC after this one has been checked in. I think that the patch 
should only contain the basic code.


- Franz
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 10011.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101102/35481bc2/attachment-0001.asc>


More information about the TYPO3-team-core mailing list