[TYPO3-core] RFC #14441: Drop support for GDlib 1.x

Christian Kuhn lolli at schwarzbu.ch
Sat May 29 18:21:17 CEST 2010


Hey,

+1 on reading and testing.
attached v2, taking some remarks into account.
@benni: Votes complete, could you take care?

Thorsten Kahler wrote:
> * maybe the comments for TYPO3_CONF_VARS.GFX.gdlib and
> TYPO3_CONF_VARS.GFX.gdlib_png should be adjusted to point to GDlib 2 as well

Any proposal?


> * Install Tool:
> ** a check for GDlib version 2.x might be added to Basic Configuration >
> GDlib

I've changed the isGD() method to test for imagecreatetruecolor() 
instead of imagecreate().


> ** in Image Processing > Current configuration one of "GDlib enabled"
> and "GDlib2 enabled" is obsolete

Removed the gdlib_2 part


> * What's the sense of keeping the attribute t3lib_stdGraphic::$truecolor
> while not respecting it, e.g. in method init()? If it's only kept for
> compatibility reasons, its usage should be captured in the deprecation log.

The variable is still in use in the code. I think it's a good idea not 
to change it now to not introduce side-effects. We could remove it with 
another rfc.

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14441_02.diff
Type: text/x-patch
Size: 17372 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100529/69a6146a/attachment.bin>


More information about the TYPO3-team-core mailing list