[TYPO3-core] FYI #14496: SQL parser does not handle ALTER TABLE with character set operation

[Xavier Perseguers]

Hi,

FYI, I committed enclosed patches to:

- TYPO3 trunk (rev. 7700)
- DBAL trunk (rev. 33599)
- DBAL_1-1 (rev. 33600)


Type: Bugfix

Bugtracker reference:
http://bugs.typo3.org/view.php?id=14496

Branches: Core trunk, DBAL trunk, DBAL_1-1

Problem:
When installing introductionpackage with DBAL, the process fails on Oracle with:

ERROR: Query could not be parsed: "SQL engine parse ERROR: No table found!: near "`index_phash` DEFAULT CHARACTER SET utf8 "". Query: "ALTER TABLE `index_phash` DEFAULT CHARACTER SET utf8"

Solution:
Enhance the SQL parser

Note #1:
Successfully tested with Oracle in addition to the unit tests

Note #2:
introductionpackage still not works but cannot as it is not DBAL-compliant. Recent changes in parser were useful in general. But I opened a bug report for that:
http://forge.typo3.org/issues/show/7944

and posted a patch that basically do not try to alter the database to UTF8 as it should already be properly configured anyway when working with DBAL.

Note #3:
introductionpackage seems to have non-conform sqldump, including columns with character set latin1, ... that makes the SQL parser fail. Will report DBAL problems to the corresponding bugtracker 
because it would be great to have introductionpackage compatible with DBAL!

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14496_core.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100527/226747ee/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14496_dbal.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100527/226747ee/attachment.asc>