[TYPO3-core] RFC #14488: prioriCalc no longer working correctly due to changes in rev 7592

[Xavier Perseguers]

Hi,

> -----------------------------------------------------
> Solution:
> -----------------------------------------------------
> Either revert the changes from 7592 for class.t3lib_div.php or apply my
> attached patch, that's keeping the "foreach" loop instead
> "while(list())" but fixes the issue.

I'm counting at least 2 follow-ups on #13670 (original bug for the while(list()) issue).

+1 by reading your patch.

I read diff of changeset 7592 and I have following comments (yes, I should put them in original thread but this post is kinda better readable and points out a bug):

--------------
t3lib_admin.php, chunk line 506 (current code):

reset($fields);
list(,$field)=each($fieldArr);
$cl_fl = ($GLOBALS['TYPO3_DB']->MetaType($fields[$field]['type'],$table) == 'I' || $GLOBALS['TYPO3_DB']->MetaType($fields[$field]['type'],$table) == 'N' || 
$GLOBALS['TYPO3_DB']->MetaType($fields[$field]['type'],$table) == 'R') ?
$field.'!=0' : $field.'!=\'\'';
foreach ($fieldArr as $field) {

the two first lines should be changed to

$field = array_shift($fieldArr)

to fix a bug that has not yet been found
--------------

Otherwise the remaining looks good to me.

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en