[TYPO3-core] RFC #14175: Bug: patch for SQL-related error in backend module belog

[Philipp Thiele]

I agree with the change of the condition from "error = 1" to "error != 0".
I was too lazy to think, sorry for that.

I've tested your correction: Patch works.


2010/5/14 Xavier Perseguers <typo3 at perseguers.ch>

> Hi,
>
> Thanks for your patch.
>
>
>  Type: Bugfix
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=14175
>>
>> Branches:
>> TYPO3_4-2 & trunk
>>
>
> 4-2 (possibly), 4-3 and trunk.
>

> DBAL is actively maintained (again) since 4-3. However the change is quite
> obvious and may find its way to 4-2.


>
>  Solution:
>> Missing comperator in where clause of sql-statement which generated the
>> list causes the error.
>> Add comperator and comperating value to the part of the where clause.
>> DBAL himself couldn't know what value may be the right, so this can't be
>> generated automatically.
>>
>
> I'd go for Björn's version, using "!= 0" instead of "= 1" to be on the safe
> side even if your version should be OK.
>
> Just for the sake of completeness, could you please report here if works
> too with "!= 0" ?
>
> --
> Xavier Perseguers
> http://xavier.perseguers.ch/en
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100514/2867117e/attachment-0001.htm>