[TYPO3-core] RFC #14324: Feature: Add spriteGeneratorAPI to support the new sprite-icon-api
Steffen Kamper
info at sk-typo3.de
Sat May 8 01:12:51 CEST 2010
Hi Steffen,
i took a first look to the patch and here are some remarks, could you
update the patch to these comments?
* please use CGL (missing spaces (function params, t3lib_spriteManager),
"AS", closing strings with wrong indentation, missing phpDocs for class
vars, missing phpDocs for functions (eg __constructor)
* we always use lower case filenames (class.t3lib_spriteManager.php)
* in t3lib_spriteManager line 119 - $cacheFile was never defined
I will do a deeper review soon.
vg Steffen
More information about the TYPO3-team-core
mailing list