[TYPO3-core] RFC #13379: Sprite Icon API

Benjamin Mack benni at typo3.org
Sat May 1 21:13:47 CEST 2010


Hey,

On 01.05.10 21:10, Steffen Kamper wrote:
> Hi Benni,
>
> generally +1 by reading and testing.
>
> There are many missing spaces (CGL), and this one:
> $str = '<img'.t3lib_iconWorks::skinImg($backPath,
> t3lib_iconWorks::getIcon($table, $row, $shaded), 'width="18"
> height="16"').(trim($params)? ' ' .trim($params): '' );
> +
>
> please use self:: here.
I don't know how this got in there, but that's not part of the API. 
Removed it manually in the attached patch.

All the best,
Benni.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sprite_api_v7a.patch
Type: text/x-patch
Size: 27865 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100501/2e3743ec/attachment-0001.bin>


More information about the TYPO3-team-core mailing list