[TYPO3-core] RFC #13418: Allow t3lib_div::_GETset() to set specified key

[Oliver Klee]

Hi,

-1 by reading because there are some "bad things" in the code:

+ (strpos($key, '|'))

strpos can both return 0 and FALSE.

+				foreach ($pieces AS $piece) {
+					$tmpRef =& $tmpRef[$piece];
+				}

AS -> as

"tmpRef" is an abbrv.


+				$GLOBALS['HTTP_GET_VARS'][$key] = $_GET =
t3lib_div::array_merge_recursive_overrule($_GET, $tmpArr);
+			} else {
+				$GLOBALS['HTTP_GET_VARS'][$key] = $_GET[$key] = $inputGet;

Double assignment ...


+	public function setUp() {
+		$this->backupGlobalVariables = array(

This variable isn't defined AFAIK.



I'll update the patch.


Oli

-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member