[TYPO3-core] RFC #13630: Bug: Status Report reports "Install Tool: disabled" when it is not.
Susanne Moog
typo3 at susannemoog.de
Thu Mar 25 20:29:35 CET 2010
Hi Gregor,
Am 25.03.2010 09:44, schrieb Gregor Hermens:
> Hi Susanne,
>
> Susanne Moog schrieb:
>>> attached patch v2 checks for the age of the ENABLE_INSTALL_TOOL file if
>>> it doesn't contain 'KEEP_FILE'. The file is deleted if it is older then
>>> 3600s, else the remaining time to live is displayed in the status report.
>>
>> +1 by reading and testing for v2, with two suggestions:
>>
>> - In case of a temporary enabled install tool I don't think we should
>> issue an actual warning, more like a notice (so severity change).
>>
>> - Don't display the remaining time in seconds, because it's pretty hard
>> to understand at a glance what "3585 seconds left" means.
>
> good point. Attached patch bug_13630v3.diff lowers the severity from warning
> to notice and reports the remaining time to live in minutes.
really nice feature now :) I have found one typo ("automaticly" instead
"automatically), but I guess that can be fixed on commiting.
So again +1 by reading and testing.
Now a core dev review is needed ;)
Best regards,
Susanne
More information about the TYPO3-team-core
mailing list