[TYPO3-core] RFC #13739: "Show" clickmenu in page tree does not work for mount pages

[Thorsten Kahler]

Hi Ernesto,

schrieb Ernesto Baschny [cron IT] am 24.03.10 00:02:
>>> - TYPO3_4-2 (rev. 7127, will be in 4.2.13)
>>
>> This introduced a bug in 4.2, due to the following line:
>>
>> $sys_page = t3lib_div::makeInstance('t3lib_pageSelect');
>>
>> t3lib_div::makeInstance() tries to load the required file smartly, but
>> since we have a naming inconsistency it fails (the file is called
>> "class.t3lib_page.php" and not "class.t3lib_pageselect.php").
>>
>> The solution is to explicitly include the file before the above call:
>>
>> t3lib_div::requireOnce(PATH_t3lib . 'class.t3lib_page.php');
> 
> Ops, thanks for bringing that to my attention. Of course I applied a
> "wrong patch" to the TYPO3 4.2 code. The check is not only failing
> because of the missing requireOnce, but it is also being applied at the
> wrong spot (that code changed in 4.3 a lot).
> 
> So attached is the follow-up to 4.2 to make it work there too. Please
> re-check. Thanks and sorry for the mess-up.
> 

I tested you patch and found out, that it breaks the funcionality for
mount pages *without* "Substitute Mount Point" set. Adding a check for
$mountPointInfo['overlay'] solves that for me.

Other than that, your patch works fine for me.

Cheers
Thorsten


-- 

Thorsten Kahler
thorsten.kahler at dkd.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13739-4_2-show-clickmenu-mp_v2.diff
Type: text/x-diff
Size: 1291 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100325/f6d0200b/attachment.diff>