[TYPO3-core] RFC #13662: [saltedpasswords] Enhance Unit Tests by testing passwords of various character classes

[Martin Kutschker]

Marcus Krause schrieb:
> Am 24.03.2010 18:02, schrieb Martin Kutschker:
>> Marcus Krause schrieb:
>>> Note:
>>> When working with the diff file, please make sure to have ISO8859-1
>>> defined for your TYPO3 core project.
>> For the hardcoded test strings? I was wondering if they are a good idea.
> 
> Could you please explain this a bit more? Yes, test string characters
> are from ISO-8859-1.

I recall a discussion of the right character set for PHP files, but cannot remember if it is
iso-8859-1 or utf-8. And as also the text editor must be set correctly I'm a bit wary when it comes
to "accented" characters in PHP code.

>> BTW, you seem to use windows-1252 not iso-8859-1.
> 
> How do you determine this? My local diff is ISO-8859-1. I assume the one
> from bugtracker has also ISO-8859-1.

That's easy. Look at this line from your patch:

$password = '^.!?"§$%#&@<>«»(){}[]=\\`Ž~,;_-+*/:\'¡¥¹';

At least Ž is not part of iso-8859-1. See

http://en.wikipedia.org/wiki/Iso-8859-1
http://en.wikipedia.org/wiki/Windows-1252

But actually it doesn't matter much for the test :)

Masi