[TYPO3-core] RFC #12661: Problem with german "Umlaute" in BE file list, no thumbs generated
Jigal van Hemert
jigal at xs4all.nl
Sun Mar 21 14:45:57 CET 2010
Thanks for the review,
Oliver Klee wrote:
> I'd prefer putting having this only in t3lib_stdgraphic and have thumbs
> call that function so we don't have to maintain duplicate code. (So no
> +1 from me yet.)
Loading t3lib_stdgraphic in thumbs.php would be too much. Can we define
wrapFileName() as static to allow thumbs.php to use it directly?
> Please also use tabs for indentation.
Sorry! The trunk version has tabs. Somewhere in the process of moving
the code to the other versions the tabs were converted to spaces. Next
version will have correct indentation.
--
Jigal van Hemert.
More information about the TYPO3-team-core
mailing list