[TYPO3-core] RFC #13283: Thumbnail generation broken for PDF files

[Andy Grunwald [wmdb]]

Hey,

the result of this bug for Stucki`s patch:

+1 by reading (Benni Mack, Oli Hader, Steffen Kamper)
+1 by testing (Andy Grunwald, Ernesto Baschny)

I think this is ready for commit, right?

Have a nice weekend!
Andy

Am 20.02.2010 09:58, schrieb Benjamin Mack:
> Hey team,
>
> this is a SVN patch request.
>
> Type: bugfix
>
> Branch: 4.3, trunk
>
> BT reference: http://bugs.typo3.org/view.php?id=13283
>
> Problem:
> Due the patch with report 0012341, the generation of thumbnails for PDF
> files does not work anymore. The problem is the missing frame parameter
> in the GraphicsMagick call.
>
> The following line was added in the function imageMagickExec (
> t3lib/class.t3lib_stdgraphic.php):
>
> $frame = $frame ? '['.intval($frame).']' : '';
>
> This means the frame parameter will not be added, if the frame number is
> 0 or empty. This is a problem for PDF files, causing GraphicsMagick to
> hang and creating an image for each page of the PDF.
>
> Solution:
> Make it right by adding the frame parameter by checking if it is "numeric".
>
> All the best,
> Benni.