[TYPO3-core] RFC #13379: Sprite Icon API

Benjamin Mack benni at typo3.org
Fri Mar 12 09:29:35 CET 2010


Hey all,

so I got a new patch attached. It changes the following:

  * let's call the hide in menu feature "hideinmenu" instead of 
"hide-in-menu".
  * The main method "getSpriteIcon()" was overworked, so the recursion 
doesn't need a separate parameter to know in which overlay level we're 
currently are.
  * The overlays are now not magically concatenated through the "+" 
symbol, but in a new parameter called overlays. The overlays parameter 
is an associative array which contains the overlays.


Two things that I still would like to fix, but haven't gotten around to 
it yet (any help is appreciated):

  * the magic file:, file::, row: and row:: should be transferred 
through a separate parameter in the getSpriteIcon() method, not in the 
string itself of the icon name, so that we have a combination of "name" 
and "type" which is making that icon sprite unique.

  * The configuration array "iconDefaultOptions", 
"iconOverlayPriorities", "iconOverlayMapping" should go into 
$TBE_STYLES['sprites'] instead of TYPO3_CONF_VARS.

Anyone up for that?

Also, please Thomas and others, give feedback on the current patch.

All the best,
Benni.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13379_v4.patch
Type: text/x-patch
Size: 19721 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100312/ae7eda09/attachment-0001.bin>


More information about the TYPO3-team-core mailing list