[TYPO3-core] RFC #13461: bugfix: wrong image-path returned in class.t3lib_tceforms.php if TYPO3-source is symlinked (backend-redesign)

[Stephan N Kellermayr]

this is an SVN patch request.

type: bugfix

bugtracker references:
http://bugs.typo3.org/view.php?id=13461

branches:
trunk, current branch

problem:
if an extension is installed in 'typo3conf/ext/' and overrides BE-icons, 
the result of 't3lib_iconWorks::skinImg' (line:4008 in 
class.t3lib_tceforms.php) is i.e. 
"../typo3conf/ext/myextension/icons/gfx/i/pages.gif".
thats correct, but if we use a symlinked TYPO3-source we get an 
incorrect path to the imagefile and so we do not get the correct 
image-dimensions from 'getimagesize' (line:4010)!

the result is, that dropdown-menus in backend-forms which contains 
icons, are not rendered correctly...icon is shown under text and text is 
positioned leftmost because of the missing image-dimensions.

icon-path without patch:
'/var/www/typo3-4.3.1/typo3/../typo3conf/ext/myextension/icons/gfx/i/pages.gif'


solution:
if 't3lib_iconWorks::skinImg' returns a filename beginning with '../' 
resolve the absolute path to the file and then get the correct 
image-dimensions.

iconPath with patch:
'/var/www/typo3-4.3.1/typo3conf/ext/myextension/icons/gfx/i/pages.gif'

(patch attached: t3lib/class.t3lib_tceforms.php.0013461.diff)


notes:
none

best regards,
Stephan N Kellermayr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: class.t3lib_tceforms.php.0013461.diff
Type: text/x-patch
Size: 979 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100311/631143c9/attachment-0001.bin>