[TYPO3-core] RFC #12066: Code cleanup: Add some constants
Oliver Klee
typo3-german-02 at oliverklee.de
Wed Mar 3 15:16:10 CET 2010
Hi,
Marcus Krause schrieb:
> I'd prefer keeping number of constants to a minimum, too.
>
> I'm fine with the character stuff and consider this to be helpful.
>
> Regarding time; I'm of the same opininion like Benjamin. Proper code
> writes time durations like 60*24*7 and you'r getting the meaning of it
> at a glance.
>
> So, IMHO, yes to the character stuff, no to constants for time durations.
Okay, so let's take this one small step at a time. (And I think I'll
open a separate RFC for adding a class with the time constants as class
constants so we don't have them in the global constants).
I've attached a patch that adds only the character constants. Once this
has been +1ed and checked in, I'll provide a second patch for actually
using these constants in the core.
Oli
--
Certified TYPO3 Integrator | TYPO3 Security Team Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12066-v4.diff
Type: text/x-patch
Size: 2286 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100303/cfaffc32/attachment.bin>
More information about the TYPO3-team-core
mailing list