[TYPO3-core] RFC #13701: Bug: @ini_set() works only on windows, on some unices it could render the function unusable

[netz-haut - stephan seitz]

This is an SVN patch request.

Type: Bugfix

Bugtracker references:
 http://bugs.typo3.org/view.php?id=13701

Branches:
 TYPO3_4-3 and trunk
 Different patches attached.
 The patch for trunk includes additional functionality to respect the OS for
 the latter mail() calls.

Problem:
 If php has been built with suhosin and runs via FCGI SAPI, the @ini_set() function call is not ignored (which is obviously expected). Instead, the php process quits without closing the fcgi handler properly.
Due to the lack of proper fcgi communication, the webserver returns an error 500.

This can be seen as a faulty php behaviour.
Anyway, the @ini_set() call does not work on most Unices, except the administrator configured the local MTA to accept manipulation from unprivileged users which is highly discouraged.
To keep the fix narrow, I suggest to use @ini_set() only if TYPO3_OS == WIN as Windows seems to be the only OS in the wild which accepts such header manipulations without any privilege problems.

Solution:
 Use @ini_set() only if TYPO3 is running on Windows.

Notes:
 See referred bugtracker entry.

Mit freundlichen Gruessen

--
Stephan Seitz
Senior System Administrator

*netz-haut* e.K.
multimediale kommunikation

zweierweg 22
97074 würzburg

fon: +49 931 2876247
fax: +49 931 2876248

web: http://www.netz-haut.de/

registergericht: amtsgericht würzburg, hra 5054



-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_13701.diff
Type: application/octet-stream
Size: 959 bytes
Desc: bug_13701.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100301/12d8fcb4/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_13701_against_trunk.diff
Type: application/octet-stream
Size: 2205 bytes
Desc: bug_13701_against_trunk.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100301/12d8fcb4/attachment-0001.obj>