[TYPO3-core] RFC: #14860: Pagerenderer - use better method for adding meta tags

Oliver Klee typo3-german-02 at oliverklee.de
Sat Jun 26 11:15:25 CEST 2010


Hi,

thanks for the new unit test. :-)

I'd like to propose some changes which will make it easier to track down
bugs when something breaks. Generally, these proposal are about making
the tests more fine-grained and more orthogonal to each other.

- add a test for the case when no meta tags are added
- test only one meta tag type at a time (I propose using data providers
for this with "speaking" array keys; if you need help, please don't
hesitate to ask me)
- add a single test for adding multiple meta tags (2 tags should be
sufficient), and test for the order in which they are rendered (if this
is relevant)


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member


More information about the TYPO3-team-core mailing list