[TYPO3-core] RFC: #14824: Sprite API: Still a wrong icon (Template Analyzer)

[Jigal van Hemert]

Georg Ringer wrote:
> Problem:
> There is a wrong icon in the template analyer

Although this seems to work, the problem lies in 
t3lib_iconWorks::mapRecordOverlayToSpriteIconName() and the code which 
calls it in this case, t3lib_tsparser_ext::ext_getTemplateHierarchyArr() 
(line 603).
t3lib_iconWorks::mapRecordOverlayToSpriteIconName() should be called 
with the record row, not a single field of that row. If you pass 
$row['root'] to it, depending on the value which is passed the code 
still assumes that this is an array and start to analyse elements of 
this array. If $row['root'] is for example '1' this value results in the 
check for the 'hidden' field to succeed and thus the hidden overlay icon 
will be shown.

The attached patch fixes the code in t3lib_tsparser_ext and results in 
the correct icon to be shown.

Still mapRecordOverlayToSpriteIconName() needs to be repaired so it will 
not treat any value for $row as an array.

-- 
Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14824_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100626/98c06857/attachment.asc>