[TYPO3-core] RFC #2049: Feature: Use Ellipse in Gifbuilder

[Oliver Klee]

Hi,

some remarks:

- Please add the "public" keyword.

- Is it really necessary to pass $im by reference?

- Please don't use abbreviations: $cords -> $coordinates, $cols ->
$colors (I guess), $im -> ?, $conf -> $configuration

- I think ImageColorAllocate is cased "imagecolorallocate" in the PHP
manual.

- Please use type hinting for the array parameters.

- Please document the expected format of the work area coordinates (in a
way that a programmer knows how to call the function by reading the
function documentation).

- You're assigning $cords two times. I guess you're using two different
sets of coordinates. Two separate variables with meaningful names would
be helpful here.


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member