[TYPO3-core] RFC: #14860: Pagerenderer - use better method for adding meta tags

Ernesto Baschny [cron IT] ernst at cron-it.de
Fri Jun 25 11:46:43 CEST 2010


Ernesto Baschny [cron IT] schrieb am 25.06.2010 11:45:
> Steffen Kamper schrieb am 25.06.2010 10:42:
> 
>> i also thought about httpEquiv as extra parameter. The reason i didn't
>> used that is, that you use this tag very seldom, but if you use extra
>> parameter you have to use FALSE all the time because the 3rd parameter.
>> Nayway if you like that extra parameter more, i have no opinions.
> 
> I think it is more confusing if you have a $name parameter which is
> ignored if there is http-equiv in the parameter list:
> 
> function addMetaTag('hello', 'content', array('http-equiv' => 'hello2'));
> 
> The "hello" will be ignored. Since it is "either the one or the other",
> semantically it makes more sense to use a single parameter for the
> "name" (be it name="" or http-equiv="").
> 
> Just my .2ct. :)

Maybe just have two different methods, which internally use one common
method:

$pageRenderer->addMetaTagName($name, $content, array $add);

$pageRenderer->addMetaTagHttpEquiv($httpEquiv, $content, array $add);

Cheers,
Ernesto


More information about the TYPO3-team-core mailing list