[TYPO3-core] RFC#14538: Icons missing in page tree for "Page contains" pages

[Steffen Ritter]

Am 13.06.2010 13:26, schrieb Susanne Moog:
> On 13.06.2010 13:21, Susanne Moog wrote:
>> On 13.06.2010 09:23, Steffen Ritter wrote:
>>> Am 13.06.2010 00:03, schrieb Steffen Kamper:
>>>> Hi,
>>>>
>>>> +1 by reading except last lines
>>>>
>>>> + krsort($recordType, SORT_NUMERIC);
>>>>
>>> Hey Steffen,
>>> sorting ok, this I will change,
>>> the Loop, might be discussable. I know that we try to get rid of
>>> while/each combination. But to me It's real bad design, quitting loops
>>> via break; It's nearly like GOTO 20...
>>>
>>
>> attached v5, without sorting (array_reverse() wouldn't work here, we'd
>> really need the ksort() - but we don't need sorting at all, see patch)
>> and without breaks, continues, while-list-constructs ... ;)
>
> arg, old version. attached the one I wanted to send...
it showed that the version with  count()  does not work either.
The record may only contain 2 entries, but the index of the highest may 
be 4 --> for (i=2; i>=0) cannot show the right icon...

fixed it going back to krsort, there's no other change atm.

PS: in current trunk the record-icon-rendering is broken.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: refixIconWorks.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100621/1133edac/attachment.txt>