[TYPO3-core] RFC #14719: Automatically create ENABLE_INSTALL_TOOL file when 1-2-3 Install Tool is used

[Jeff Segars]

On 6/16/10 4:29 PM, Helmut Hummel wrote:
> Hi Jeff,
>
> On 16.06.10 22:20, Jeff Segars wrote:
>>
>> After talking it over with Ben, here's v2 of the patch that takes
>> Philipp's idea and Steffen's original idea into account and also
>> addresses the security issues.
>>
>> If typo3conf/FIRST_INSTALL is present, we immediately delete it and
>> create typo3conf/ENABLE_INSTALL_TOOL. If the file is not present or
>> could not be deleted, then we do not create ENABLE_INSTALL_TOOL and the
>> normal lock message is shown.
>>
>> Any thoughts?
>
> One question and one remark:
>
> Question: The typo3conf/FIRST_INSTALL file will only be there if the
> quickstart package is used, or will it be provided in the dummy package?

That's a good question. Personally, I would vote that it provided in all 
of the packages. We would certainly include it in the packages that we 
create for Web-Empowered Church.

> Remark: Please use t3lib_div::fixPermissions after creating the file.

This code lives in typo3/install/index.php and the various 
TYPO3_CONF_VARS are not available yet, so calling fixPermissions() won't 
work without some additional refactoring.

Thanks,
Jeff