[TYPO3-core] RFC: #14717: [Usability] Add delay to close the context menu

Dmitry Dulepov dmitry.dulepov at gmail.com
Mon Jun 14 13:07:24 CEST 2010


Hi!

Two notes.

Steffen Kamper wrote:
> +		this.doNotHide = false;

What about a more speaking name, such as "delayClickMenuHide"? This is
exactly what this variable is for. 'doNotHide' is indescriptive and prone
to abuse.

> +		window.setTimeout(function() {
> +			if (!Clickmenu.doNotHide) {
> +				Element.hide(obj);
> +			}
> +		}, 500);

Why don't you use Ext.util.DelayedTask? Just a question.

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 core&security teams member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/


More information about the TYPO3-team-core mailing list