[TYPO3-core] RFC#14538: Icons missing in page tree for "Page contains" pages

Susanne Moog info at susannemoog.de
Sun Jun 13 13:21:56 CEST 2010


On 13.06.2010 09:23, Steffen Ritter wrote:
> Am 13.06.2010 00:03, schrieb Steffen Kamper:
>> Hi,
>>
>> +1 by reading except last lines
>>
>> + krsort($recordType, SORT_NUMERIC);
>>
> Hey Steffen,
> sorting ok, this I will change,
> the Loop, might be discussable. I know that we try to get rid of
> while/each combination. But to me It's real bad design, quitting loops
> via break; It's nearly like GOTO 20...
>

attached v5, without sorting (array_reverse() wouldn't work here, we'd
really need the ksort() - but we don't need sorting at all, see patch)
and without breaks, continues, while-list-constructs ... ;)

Susanne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14538_v5.diff
Type: text/x-diff
Size: 3593 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100613/d5771773/attachment-0001.diff>


More information about the TYPO3-team-core mailing list