[TYPO3-core] RFC #14636: Improvements to new Backend skin

[Philipp Gampe]

Am 11.06.2010, 22:21 Uhr, schrieb Steffen Gebert  
<steffen at steffen-gebert.de>:
>> Some improvements to the new BE skin are still needed
> Come on! Could I please get some reviews for this?

might be, because there are so many different files with different  
versions ;)

the following hunk (#1) failed

--- t3lib/class.t3lib_befunc.php        (Revision 7807)
+++ t3lib/class.t3lib_befunc.php        (Arbeitskopie)
@@ -2481,7 +2481,7 @@


I did not read through all changes, not did I test everything.
I hope this is correct:
svn st| grep -vc ".orig"
56

All icons are "messed up". I guess the sprites are misplaced ... So I  
can't give you a positive review now. However I spotted a lot some new  
icons I like. Some seems to have a white border through. Cache cleaning /  
deleting all temp files did not help. Nor installing/uninstalling an EXT.
I did unzip the attached zip-file to the root folder.

Maybe you can post a combined patch for easier testing?
Additionally, patch complained about stripped CRs a lot ?! Most patches  
only worked with fuzz.

for easier review: here is the complete svn st| grep -v "orig"
M       t3lib/class.t3lib_tceforms.php
M       t3lib/class.t3lib_befunc.php
M       t3lib/class.t3lib_fullsearch.php
M       typo3/stylesheets/install/install.css
M       typo3/sysext/beuser/mod/index.php
M       typo3/sysext/t3skin/extjs/xtheme-t3skin.css
M       typo3/sysext/t3skin/images/login/typo3logo-white.png
M       typo3/sysext/t3skin/images/sprites/t3-icon-status.png
M       typo3/sysext/t3skin/images/sprites/t3-icon-apps.png
M       typo3/sysext/t3skin/images/sprites/t3-icon-places.png
M       typo3/sysext/t3skin/images/sprites/t3-icon-mimetypes.png
M       typo3/sysext/t3skin/images/sprites/t3-icon-actions.png
M       typo3/sysext/t3skin/images/icons/actions/system-cache-clear.png
M       typo3/sysext/t3skin/images/icons/actions/edit-undo.png
M        
typo3/sysext/t3skin/images/icons/actions/system-extension-install.png
M        
typo3/sysext/t3skin/images/icons/actions/system-extension-uninstall.png
?        
typo3/sysext/t3skin/images/icons/apps/pagetree-folder-contains-shop.png
?        
typo3/sysext/t3skin/images/icons/apps/pagetree-folder-contains-fe_users.png
?        
typo3/sysext/t3skin/images/icons/apps/pagetree-folder-contains-board.png
?        
typo3/sysext/t3skin/images/icons/apps/pagetree-folder-contains-news.png
?        
typo3/sysext/t3skin/images/icons/apps/pagetree-folder-contains-approve.png
M       typo3/sysext/t3skin/images/icons/apps/filetree-mount.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-no-icon-found-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-shortcut-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-mountpoint-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-shortcut-hideinmenu.png
M       typo3/sysext/t3skin/images/icons/apps/pagetree-page-domain.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-frontend-user-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-shortcut-external-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-advanced-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-frontend-users-root.png
M        
typo3/sysext/t3skin/images/icons/apps/pagetree-page-backend-users-root.png
M       typo3/sysext/t3skin/images/icons/apps/pagetree-page-shortcut.png
M       typo3/sysext/t3skin/stylesheets/structure/element_csm.css
M       typo3/sysext/t3skin/stylesheets/structure/element_tceforms.css
M       typo3/sysext/t3skin/stylesheets/structure/element_version.css
M       typo3/sysext/t3skin/stylesheets/structure/module_user_settings.css
M       typo3/sysext/t3skin/stylesheets/structure/element_tree.css
M       typo3/sysext/t3skin/stylesheets/structure/module_web_page.css
M       typo3/sysext/t3skin/stylesheets/structure/main_content.css
M       typo3/sysext/t3skin/stylesheets/structure/module_menu.css
M       typo3/sysext/t3skin/stylesheets/structure/module_web_list.css
M       typo3/sysext/t3skin/stylesheets/structure/element_csh.css
M       typo3/sysext/t3skin/stylesheets/visual/element_csm.css
M       typo3/sysext/t3skin/stylesheets/visual/element_tceforms.css
M       typo3/sysext/t3skin/stylesheets/visual/element_version.css
M       typo3/sysext/t3skin/stylesheets/visual/toolbar_username.css
M       typo3/sysext/t3skin/stylesheets/visual/module_web_page.css
M       typo3/sysext/t3skin/stylesheets/visual/main_content.css
M       typo3/sysext/t3skin/stylesheets/visual/element_tab.css
M       typo3/sysext/t3skin/stylesheets/visual/element_csh.css
M       typo3/sysext/cms/layout/class.tx_cms_layout.php
M       typo3/sysext/install/Resources/Public/Stylesheets/general.css
M       typo3/sysext/install/Resources/Public/Stylesheets/install_login.css
M       typo3/class.db_list_extra.inc
M       typo3/alt_clickmenu.php


Best regards
-- 
Philipp Gampe