[TYPO3-core] RFC #11447: unwanted control fields exported in csv file

Christian Kuhn lolli at schwarzbu.ch
Fri Jun 11 02:05:28 CEST 2010


Hey,

Peter Niederlag wrote:
>>> Attached v2 with some array magic ;)
>> Slight modifications with v3.
> 
> +1 by reading and testing.
> 
> Maybe comments should read:
> 
> // add header row, control fields will be reduced inside addToCSV()
> 
> instead of:
> // Reduce header row by control fields and add to csv output

Much better :) Will change before commit. Thank for review, and great to 
have you on board again, Peter!

As the patch is a full rework from the first version, a full review 
cycle would be great. Thus, with Peters review we're now just missing a 
testing vote from anyone.

Pretty easy to test if you change the echo call in the output method to 
debug() and comment the content type line.

Thanks
Christian


More information about the TYPO3-team-core mailing list