[TYPO3-core] RFC: #14663: t3lib_utility_Client::getBrowserInfo returns gecko build date rather than version

Stanislas Rolland typo3 at sjbr.ca
Thu Jun 10 00:06:42 CEST 2010


Le 2010-06-09 16:23, Steffen Kamper a écrit :
> Hi Stan,
>
> Stanislas Rolland schrieb:
>> Le 2010-06-09 14:02, Stanislas Rolland a écrit :
>>> Hi Steffen,
>>>>
>>>> after #14458 is committed, the patch doesn't apply clean.
>>>>
>>>> Here is the updated one, and an integrated test for it.
>>>>
>>> Thanks for this.
>>>
>>> +1 from reading and testing.
>>>
>> Oops! no, I think it should be:
>>
>> preg_match_all('/rv:([0-9\.]*)/', strtolower($userAgent), $version);
>>
>
>
> why, do you expect other chars in revision?
>
Because, on testing, a string starting with the revision number but much 
longer than just the revision number was returned. Also, I think it is 
better not to rely on the closing parenthesis.

Stan




More information about the TYPO3-team-core mailing list