[TYPO3-core] Re: Re: RFC#14546: Cleanup: IE 6 does not support alpha-transparent-pngs which looks "&%/§$%&" with sprites
Benjamin Mack
benni at typo3.org
Sat Jun 5 09:06:40 CEST 2010
Hey Steffen,
+1 after reading, I'll do the testing today.
Questions / Remarks about your patch:
On 31.05.10 18:38, Steffen Ritter wrote:
> + // handle stupid IE6
> + $userAgent = t3lib_div::getIndpEnv('HTTP_USER_AGENT');
Please don't write stuff like that in the comments / documentation
"handle stupid IE6".
> + if(!(strpos($userAgent, 'MSIE 6') === false)
> + && strpos($userAgent, 'Opera') === false
> + && strpos($userAgent, 'MSIE 7') === false) {
> + //make sure we match IE6 but not Opera or IE7
Apparantly it's necessary to have a check like this, but in 1 month
nobody will know why we need the check above instead of a simple
if (strpos($userAgent, 'MSIE 6') !== false)
Can you tell me why this is necessary here? Also, shouldn't we use the
BROWSER/CLIENT_INFO we already have from t3lib_div?
All the best,
Benni.
More information about the TYPO3-team-core
mailing list