[TYPO3-core] RFC #14354: Bug: fix percentage of changes in Workspace Manager -> "Show differences inline"

[Christian Kuhn]

Hey.

Marco Huber wrote:
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=14354
> 
> Branches:
> TYPO3_4-3 & trunk
> 
> Problem:
> When you select the option "Show differences inline" in the Workspace 
> Manager the percentage of changes is shown twice and incorrect. See this 
> screenshot: http://img140.imageshack.us/img140/8586/workspaceerror.jpg
> 
> Solution:
> - twice: typo3\mod\user\ws\class.wslib_gui.php Line 450 has hardcoded 
> labels, line 451 uses LL-File. So lets delete line 450
> - incorrect: in the LL-File typo3\sysext\lang\locallang_mod_user_ws.xml 
> Line 145 there should be "%d%% change:" instead of "%%% change:"

Great first patch :)

+1 on reading and testing.

Attached a diff with proper file structure to ease a second review.

Thanks
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14354_01.diff
Type: text/x-patch
Size: 1418 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100602/5c2ef2fe/attachment-0001.bin>