[TYPO3-core] RFC #13750: Bug: Several GIFBUILDER features broken for IM4, IM6 and GM

[Joerg Wagner [DigiLog]]

Hi,

I recommend adding some more cases to the unit testing of the affected 
function.
In [1] I gave some examples that were not treated correctly by a 
proposed patch at that time. These patterns should be checked by the 
testcases to stay on the safe side in the future:

// Multiple blanks in a quoted parameter
t3lib_div::unQuoteFilenames("aa 'bb cc dd' ee")
: array =
   0: string = "aa"
   1: string = "'bb cc dd'"
   2: string = "ee"

// Non word chars in a parameter
t3lib_div::unQuoteFilenames("aa bb()[]!;cc dd 'aa bb()[]!;cc dd'")
: array =
   0: string = "aa"
   1: string = "bb()[]!;cc"
   2: string = "dd"
   3: string = "'aa bb()[]!;cc dd'"

// Single quotes may not close double quoted strings and vice versa
t3lib_div::unQuoteFilenames("'aa bb\" cc'")
: array =
   0: string = "'aa bb\" cc'"
t3lib_div::unQuoteFilenames("\"aa bb' cc\"")
: array =
   0: string = "\"aa bb' cc\""


Sorry that I do not provide the modified testcase patches myself, but I 
still have to get acquainted with this unit testing stuff (and will 
probably do so soon).

Cheer, Jörg.

[1]  http://bugs.typo3.org/view.php?id=13750 - Posting 27.04.10 16:22


schrieb Oliver Klee am 29.05.2010 14:01:
> Hi,
>
> Am 29.05.2010 13:50, schrieb Jigal van Hemert:
>> Are these blocking issues? (Just to be sure how much this is needed ;-) )
>
> No, just things to make debugging, code reading and *patch reviews*
> easier (especially concerning finding problems in the patch).
>
>
> Oli