[TYPO3-core] RFC#14849: Bugfix: Sprites - user defined page types/modules are not respected anymore

[Susanne Moog]

Hi,

the good news first: the patch works as advertised and in general I
think it's the right solution, however I get deprecation log entries for
all the default icons, not only for my custom ones.

This might be because there still is the PAGE_TYPES declaration in stddb
> tables.php (why did you add the deprecation note in the header but did
not change the definition to the new method?)

Second point:
In t3lib_iconwork is (lines 200 ff):

if ($table=='pages') {
				// @TODO: RFC #7370: doktype 2&5 are deprecated since TYPO3 4.2-beta1
			if ($row['nav_hide'] && ($row['doktype']==1||$row['doktype']==2))
$row['doktype'] = 5;	// Workaround to change the icon if "Hide in menu"
was set

			if (!$iconfile = $PAGES_TYPES[$row['doktype']]['icon']) {
				$iconfile = $PAGES_TYPES['default']['icon'];
			}
			if ($row['module'] && $ICON_TYPES[$row['module']]['icon']) {
				$iconfile = $ICON_TYPES[$row['module']]['icon'];
			}


doesn't this mean that if we deprecate PAGES_TYPES and ICON_TYPES
another method has to be used here to find the page icons?

Cheers,

Susanne