[TYPO3-core] RFC #12322: cHash is generated when no parameters are given

Dmitry Dulepov dmitry at typo3.org
Tue Jul 13 14:54:33 CEST 2010


Hi!

Steffen Kamper wrote:
> Also one remark, instead substr($addQueryParams, 0, 1) i would use
> t3lib_div::isFirstpartOfString.
> I also would use strict comparison.

It would be two built–in function calls + a single user function call
instead of a single built–in function call... I think using that function
is not justified when comparing to a constant.

-- 
Dmitry Dulepov
TYPO3 core&security teams member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/


More information about the TYPO3-team-core mailing list