[TYPO3-core] !!!!! Re: RFC #1235

Dmitry Dulepov dmitry at typo3.org
Sun Jul 11 08:08:26 CEST 2010


Hi all!

Please, don't commit this yet. I feel an extra check of this patch is
needed. I'll do it on Monday.

Nikolas Hagelstein wrote:
> Solution:
> The path link is generated by tx_indexedsearch::linkPage. This function
> generates the link parameters by unserializing $row['cHashParams'].
> For the path no 'cHashParams' exists in the passes row parameter.
> 
> Adding it solves the issue.

The reason: I feel that linkPage should take care of validating and passing
proper parameters to pi_linkToPage. I do not like the proposed solution by
reading because it does not look clean to me. I can be wrong, this is why I
want to investigate this.

Please, hold the commit.

-- 
Dmitry Dulepov
TYPO3 core&security teams member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/


More information about the TYPO3-team-core mailing list