[TYPO3-core] RFC #13750: Bug: Several GIFBUILDER features broken for IM4, IM6 and GM

[Joerg Wagner [DigiLog]]

REMINDER#4
This is not a minor issue. T3 in all recent 4.x versions is defunct on 
WAMP servers!

Please be aware that this patch does NOT change the handling of frame 
parameters in any way! It simply changes unQuoteFilenames() to work on 
double and single quotes instead of single quotes only.

The truth is, that the version of unQuoteFilenames() in ALL recent cores 
does not handle frame parameters correctly, when they appear outside of 
quotes.

So please let us at least get an identical behavior for Win and *nix. 
And let us proceed from there. The only thing that is changed by the 
patch is that the system will work on WAMP. The handling of frame 
parameters outside quotes is not changed and thus the safe mode behavior 
of the function remains untouched (even if it may not be correct).

Cheers,
Jörg.


schrieb Benjamin Mack am 29.05.2010 12:21:
> Hey guys,
>
> just so you know: The $frame parameter was moved OUT of the wrap
> filename because of a problem with the frames [0] when using safe_mode
> on Unix machines. This was a major bug and was introduced with 4.3.1 (I
> think), and fixed with 4.3.2. So, please don't make the same mistake again.
>
> On 29.05.10 11:12, Jigal van Hemert wrote:
>> - $cmd = t3lib_div::imageMagickCommand('convert', $params . ' ' .
>> $this->wrapFileName($input) . $frame . ' ' .
>> $this->wrapFileName($output));
>> + $cmd = t3lib_div::imageMagickCommand('convert', $params . ' ' .
>> $this->wrapFileName($input . $frame) . ' ' .
>> $this->wrapFileName($output));
>
> I think that we need to have this patch tested on
>
> * Unix + Windows
> * safe_mode on/off
> * PDF thumbnail generation / GIFBuilder
>
> to be complete.
>
> All the best,
> benni.