[TYPO3-core] RFC #14970: ts browser condition results in error if browser is unknown

Gosign | Caspar Stuebs caspar at gosign.de
Wed Jul 7 10:15:34 CEST 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This is a svn patch request

Bugtracker:
http://bugs.typo3.org/view.php?id=14970
(http://bugs.typo3.org/view.php?id=14838 also)

Branches:
4.4, trunk

Problem:
If a [browser = ...] condition is set in ts and the calling browser is
unknown, the condition produces an error.
Within the return-array of the function
t3lib_utility_client::getBrowserInfo() there is a new key called 'all',
should containing an array, which is now used for the condition-testing
in t3lib_matchcondition_abstract->evaluateConditionCommon().
If the browser is 'unknown' neither the new key 'all', nor the key
'version' are initialized for the return array.

Solution:
Add the array-keys 'all' and 'version' to the return-array, if browser
is unknown.

Note:
In the first patch on the bugtracker I added the value 'unknown' to the
key 'version', but I think this is not good.
In the second version of the patch, attached here, the value for
'version' is empty.

Viele Grüsse

Caspar Stuebs
Entwicklung

***Gosign im Jahrbuch der Werbung 2009***

NEW | We web pink: www.bebegeneration.de
We web green: www.greenpeace-hamburg.de
We web baguette: www.renault-safety.com

- --

Gosign media. GmbH | We web ideas.
Lokstedter Weg 36 | 20251 Hamburg
Tel. +49 (0) 40 / 31 70 15 00 | Fax  +49 (0) 40 / 31 70 15 02
eMail caspar at gosign.de | Internet www.Gosign.de | Skype caspar.stuebs

Amtsgericht Hamburg HRB 112197 | Ust-IdNr. DE215891388
Geschäftsführung Bert Gogolin

Greenpeace energy: Gosign läuft mit ehrlichem Strom.
Diese Mail bitte nur ausdrucken, wenn es wirklich sein muss.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw0N6YACgkQBN8gVNLcSL7twwCeI0QmrDsp4Uf3Y54MxydmNZQa
Sh8AoK2muVcimoCSoacF0RUaanl3VoYT
=yXrC
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bug_14970_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100707/3c21222a/attachment.asc>


More information about the TYPO3-team-core mailing list