[TYPO3-core] RFC #15002: Enhancement of t3lib_div::isFirstPartOfStr

[Michiel Roos [netcreators]]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7/5/10 11:35 PM, Steffen Kamper wrote:
> Hi,
> 
> +1 on reading and testing.
> 
> Anyway i attached the modifiied patch which
> * early return when one parameter is not a string
> * early return when any string is empty string
> * renamed vars to nameful vars
> * added CGL
> 
> please verify the performance, if it's the same, i will commit it.

No, wait . . .

The docs say: If needle is not a string, it is converted to an integer
and applied as the ordinal value of a character.

http://de.php.net/strpos

So . . . it's best to let strpos decide en and not bail out if the
parameter is not a string.

Also, please adjust the performance php scripts and run thorough tests.

We need to make the fastest TYPO3 version ever ;-)

- -- 
Met vriendelijke groet / Warm regards,

Michiel Roos
Chief Technical Officer
Netcreators: Open Source, Open Minds, Open People
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwy5XgACgkQLMRd8N/xuiweqgCfbIlQ/EQPd8K2QUZV5W3chC4h
FN4Anjk3hYWiDEYdllxpHW6J7HeUgfYW
=I5Ml
-----END PGP SIGNATURE-----