[TYPO3-core] RFC #2049: Feature: Use Ellipse in Gifbuilder

[Kjeld Schumacher]

REMINDER #1

bye Kjeld

On 06/25/2010 07:47 PM, Kjeld Schumacher wrote:
> Hi,
> On 06/25/2010 06:35 PM, Oliver Klee wrote:
>> Hi,
>>
>> some remarks:
>>
>> - Please add the "public" keyword.
>>
> added
>> - Is it really necessary to pass $im by reference?
>>
> hm I don't know...
>> - Please don't use abbreviations: $cords ->  $coordinates, $cols ->
>> $colors (I guess), $im ->  ?, $conf ->  $configuration
>>
>>    - I think ImageColorAllocate is cased "imagecolorallocate" in the PHP
>> manual.
> right..
>> - Please use type hinting for the array parameters.
>>
> done
>> - Please document the expected format of the work area coordinates (in a
>> way that a programmer knows how to call the function by reading the
>> function documentation).
>>
> i provided a sample typoscript and explained $workArea and $conf
>> - You're assigning $cords two times. I guess you're using two different
>> sets of coordinates. Two separate variables with meaningful names would
>> be helpful here.
>>
> hope I found matching names...
>> Oli
> Hi,
> hope everything is ok now... :-)
>
> Have a nice weekend...
>
> Bye Kjeld