[TYPO3-core] RFC #14968: Feature: Add Test Cases for t3lib_div::validIP($ip)

[Oliver Klee]

Hi,

I think the test names could be improved/simplified a bit:

checkValidIpValidIpProvider -> validIpDataProvider
checkValidIpInvalidIpProvider -> invalidIpDataProvider
(for this data provider, you've also used the array key "zero" twice)

checkValidIpValidIp -> checkValidIpWithValidIp
checkValidIpInvalidIp -> checkValidIpWithInvalidIp

I also propose to move the data providers above the tests.


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member