[TYPO3-core] RFC #14810: Bug: System extension impexp don't stores selected tables, relations and static relations

[Ernesto Baschny [cron IT]]

Hi,

yes, a follow-up to the while-each with foreach replacement patch. I 
have found that issue myself earlier today, and was just about to write 
the bug report, when I found it already posted. :)

Commited to:
- trunk (rev. 8079 for 4.5-dev)
- TYPO3_4-4 (rev. 8080, will be in 4.4.1)

To avoid these situations in future, maybe we should adopt the syntax:

   foreach ($array as $key => $_)

if we are not interested in the values of the array, just the keys. This 
is way faster than doing an array_keys before. And the $_ is certainly a 
variable that you won't be using in your regular code.

Cheers,
Ernesto

Kjeld Schumacher schrieb:
> On 06/25/2010 07:09 AM, Steffen Ritter wrote:
>> Am 24.06.2010 23:16, schrieb Thomas Juhnke:
>>> This is an SVN patch request.
>>>
>>> Type: Bugfix
>>>
>>> Bugtracker references:
>>> http://bugs.typo3.org/view.php?id=14810
>>>
>>> Branches:
>>> TYPO3_4-4
>>>
>>> Problem:
>>> The impexp system extension don't store the selected tables, relations
>>> and static relations after clicking "refresh".
>>>
>>> Solution:
>>> In lines 1645:1649 a foreach loop over the TCA is overriding the $value
>>> var and therefore a "[ctrl]" section is is available later on
>>> determining if a value is selected in the incoming data. I suggest to
>>> change the $value var in that loop to "$table_value".
>>>
>>> Notes:
>>>
>>> This is my first RFC in the Core list, I hope I made no mistakes and the
>>> patch will make it into the next bugfix release.
>>>
>>> Blessings,
>>>
>>> Thomas
> +1 by reading
> 
> Kjeld