[TYPO3-core] RFC #13193: Bug: Day of week in scheduler cron command is not calculated correctly

Francois Suter fsu-lists at cobweb.ch
Fri Jan 29 09:03:49 CET 2010


Hi,

> Solution:
> Add a test if day of month is not restricted (* in 3rd part) and unset
> already calculated list of days for day of week calculation, otherwise
> combine arrays.

+1 on reading and testing, thanks for taking care and sorry for the 
delay in reviewing. I'm also very happy to have a unit test for this 
calculation. It could probably be expanded to check other calculations, 
but it's already good to have it at all.

Two notes:

1) please change "false" to "FALSE" in the parts affected by your patch, 
as it was decided for uppercase use in the latest version of the CGLs

2) while you're at it maybe also add another TODO: "Support usage of day 
names in day of week field ("mon", "sun", etc.)" as this is also 
expected to be usable in crontab syntax

If I had submitted this patch myself I probably would have used my FYI 
rights on the Scheduler to commit right away, so unless someone opposes, 
I think you can go ahead and commit it.

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch


More information about the TYPO3-team-core mailing list