[TYPO3-core] RFC #13279: defaults are not applied using "page after" in "new element wizard"

Steffen Kamper info at sk-typo3.de
Mon Jan 18 11:39:09 CET 2010


Hi Masi,

Martin Kutschker schrieb:
> Steffen Kamper schrieb:
>> Hi,
>>
>> wait a moment.
>>
>> If there is a negative pid this means "after" abs(pid). But reading
>> PageTS has to be done from parent instead from pid. Example:
>>     // Negative PID values is pointing to a page on the same level as
>> the current.
>>     if ($positionPid < 0) {
>>         $pidRow = t3lib_BEfunc::getRecordWSOL('pages',
>> abs($positionPid), 'pid');
>>         $parentPageId = $pidRow['pid'];
>>     } else {
>>         $parentPageId = $positionPid;
>>     }
>>
>> this is the equivalent in TV, so we need the same check here.
> 
> Does this info change anything in my original patch? If anything it shows that the decision to abuse
> the sign of the pid for something completely unrelated was a bad decision.
> 

yes it does, same chack has to be done there too.

And right, using negative pid for position and negative pid for versions 
are two usages with same field and different result which is bad concept.

vg Steffen


More information about the TYPO3-team-core mailing list