[TYPO3-core] RFC #13026 : Install tool doesn´t reconize comments in localconf.php

[Xavier Perseguers]

Hi,

On 01/08/10 11:35 PM, Stefano Kowalke wrote:
> Its figure out, that the out-of-the-Box solutions with
> php_strip_whitespace or the tokenizer technique are not useable for this
> task.
>
> Version 4 of the patch fix an error in verion 3 and take care for these
> comments:
>
> /* comment */
>
> /*
> comment */
>
> /* comment
> */
>
> /*
> comment
> */
>
> # comment
>
> Those who start with // were ignored out of the box.

I must admit, I really would like having unit tests here. That's quite easy to do for this method and anyone would then be able to ensure it works without having to "manually" test what is changed.

Regards

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en

One contribution a day keeps the fork away