[TYPO3-core] RFC: #8903: redirect url is not passed with get/post method

[Ernesto Baschny [cron IT]]

Hi,

about this "old cheese".

Doesn't this patch breaks the fix we had in #8677 [1] "Redirect after
logout doesn't work"?

This hunk was in #8677 [2]:

-				} elseif ($this->logintype === 'logout') { // after logout
+				} elseif ($this->logintype === 'logout' || !$this->logintype) { //
after logout

which was then reversed in #8677 [3]. This makes this setup not work:

plugin.tx_felogin_pi1 {
  ...
  redirectMode = logout
  redirectPageLogout = 57
  redirectDisable = 0
  ...
}

And having the "logout" FORM on every page. This would place the
redirect_url in the "action=" of the logout-FORM and will only work in
4.2.2 and 4.2.3 and stop working again in 4.2.4.

Steffen, can you confirm this?


[1] http://bugs.typo3.org/view.php?id=8677
[2] #8677 http://forge.typo3.org/repositories/revision/typo3v4-core/4068
[3] #8903 http://forge.typo3.org/repositories/revision/typo3v4-core/4467

Steffen Kamper schrieb:
> Hi,
> 
> thx guys!
> 
> committed to trunk rev 4461 with change of varname as Ingmar suggested.
> 
> vg Steffen
> 
> Ingmar Schlecht schrieb:
>> Hi Steffen,
>>
>> Steffen Kamper schrieb:
>>> Hi,
>>>
>>> this is a SVN patch request.
>>>
>>> Type: Bugfix
>>>
>>> BT Reference: http://bugs.typo3.org/view.php?id=8903
>>>
>>> Branches: Trunk, 4.2
>>>
>>> Problem:
>>> When the url contains redirect_url and redirect method is set to getpost
>>> it will not proceeded as the parameter is not passed correctly.
>>>
>>> Solution:
>>> treat the case in processRedirect when $this->logintype isn't set and
>>> pass the redirect_url. Also pass it after login error.
>>
>> I just reviewed the code, +1.
>>
>> Just one nitpicking: The URL should be named $gpRedirectUrl instead of
>> $gpRedirecturl, so please change that before committing.
>>
>> I suggest that you commit this right away, because:
>>   - you said (on skype) that a bunch of people has tested this
>>   - felogin is basically your baby
>>   - it's just a small patch, and I can confirm that old functionality
>>     wouldn't break
>>
>> So go for it!
>>
>> cheers
>> Ingmar
>>
>>