[TYPO3-core] RFC #13026 : Install tool doesn´t reconize comments in localconf.php

[Oliver Hader]

Hi,

Am 13.12.09 15:30, schrieb Stefano Kowalke:
> This is SVN patch request.
> 
> Type: Bugfix
> 
> Branches: 4.3, trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=13026
> 
> Problem:
> If you have a localconf.php like this below and you switch to a new
> major version (4.2 -> 4.3), Update Wizard suggest you to perform an
> update. After this you got a message like this:
> "changeCompatibilityVersion
> Update successful!

I see... However, instead of wringing own parsers, searching for comment
literals and interpreting them, maybe it's possible to use a PHP method
to read the contents with stripping the comments, for example:

php_strip_whitespace($fileName)

Thus, nobody has to take care where comments begin - for instance the
patch misses the fact that " /* comment" and " //" could be valid
comment literals as well...

Thanks in advance for giving it a try!

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3