[TYPO3-core] RFC: #13675: Use array_map() for t3lib_div::intExplode

Christian Kuhn lolli at schwarzbu.ch
Fri Feb 26 18:48:59 CET 2010


Christian Kuhn wrote:
> * Committed to trunk rev. 7053
> * Committed to 4.3 rev. 7054
> 
> after my additional +1 on reading and testing, my profiling showed a 
> performance boost of 50% for this method.

array_walk() expects the callback method to work on parameters by 
reference, but intval returns the value. Thus, the method did not work 
as before and intval had no effect.

Attached patch using array_map() was committed as a follow-up to:
* trunk rev. 7058
* 4.3 rev. 7059

Attached testcase was committed to:
* trunk rev. 7060

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13675_followup.diff
Type: text/x-patch
Size: 539 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100226/c5cb6503/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13675_testcase.diff
Type: text/x-patch
Size: 709 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100226/c5cb6503/attachment-0001.bin>


More information about the TYPO3-team-core mailing list